Feature/timing update requires signature #11006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost-not-in-the-shell
requested review from
a team,
imeckler and
mrmr1993
as code owners
ghost-not-in-the-shell
added
the
ci-build-me
mrmr1993
suggested changes
May 18, 2022
ghost-not-in-the-shell
changed the title
mrmr1993
suggested changes
May 20, 2022
| let timing = Party.Update.timing party in | ||
| let local_state = | ||
| Local_state.add_check local_state | ||
| Creation_of_timed_account_without_signature |
There was a problem hiding this comment.
Can you use the existing Update_not_permitted_timing_existing_account, and remove that old check for account_is_new?
mrmr1993
approved these changes
May 20, 2022
…iming-update-requires-signature
deepthiskumar
requested changes
May 23, 2022
mrmr1993
approved these changes
May 24, 2022
| in | ||
| check_zkapp_failure Transaction_status.Failure.Overflow result ) ) | ||
|
|
||
| let%test_unit "zkApp command, create timed account with wrong authorization" |
There was a problem hiding this comment.
Could you write a test for correct authorization and a test for the new case (fails when the account is already timed)?
| let state_view = | ||
| Transaction_snark_tests.Util.genesis_state_view | ||
| in | ||
| let result = |
There was a problem hiding this comment.
call apply_zkapp_commands_at_slot instead (for all tests you added)? It applies both in snark and out of snark
…iming-update-requires-signature
deepthiskumar
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
This PR adds hard-coded checks for signature of timed account.
Explain how you tested your changes:
I added a new unit test for the created of timed account without signature.
Checklist: